KEMBAR78
Migrate to Microsoft.IdentityModel.JsonWebTokens by iamcarbon · Pull Request #476 · passwordless-lib/fido2-net-lib · GitHub
Skip to content

Migrate to Microsoft.IdentityModel.JsonWebTokens #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 15, 2024
Merged

Migrate to Microsoft.IdentityModel.JsonWebTokens #476

merged 17 commits into from
Jan 15, 2024

Conversation

@iamcarbon
Copy link
Contributor

@iamcarbon iamcarbon commented Dec 22, 2023 •
edited
Loading

This PR:

  • Enables C#12
  • Updates the library to use the modernized Microsoft.IdentityModel.JsonWebTokens library
  • Updates the demos to use .net8.0 (the main library continues to target net6.0)
  • Fixes various dotnet format violations
  • Updates xunit to the latest version
  • Updates System.Formats.Cbor to 8.0.0
  • Replaces DataHelper.Concat with collection expressions

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023 •
edited
Loading

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (5284757) 74.11% compared to head (a7144c0) 73.88%.

Files Patch % Lines
...c/Fido2/Metadata/Fido2MetadataServiceRepository.cs 0.00% 12 Missing ⚠️
...ido2/Objects/DevicePublicKeyAuthenticatorOutput.cs 0.00% 6 Missing ⚠️
Src/Fido2/AuthenticatorAssertionResponse.cs 50.00% 1 Missing ⚠️
Src/Fido2/AuthenticatorAttestationResponse.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   74.11%   73.88%   -0.23%     
==========================================
  Files         100       99       -1     
  Lines        2712     2692      -20     
  Branches      443      457      +14     
==========================================
- Hits         2010     1989      -21     
- Misses        598      599       +1     
  Partials      104      104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamcarbon iamcarbon mentioned this pull request Dec 22, 2023
Closed
@iamcarbon
Copy link
Contributor Author

@abergs Ready for review.

joegoldman2
joegoldman2 reviewed Dec 22, 2023
View reviewed changes
joegoldman2
joegoldman2 reviewed Dec 23, 2023
View reviewed changes
Copy link
Contributor

@joegoldman2 joegoldman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left a few comments. Otherwise, this migration looks awesome!

@iamcarbon
Copy link
Contributor Author

This also addresses CVE-2024-21319

@abergs Let me know when you have a chance to review.

abergs
abergs approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@abergs abergs merged commit 81e125d into passwordless-lib:master Jan 15, 2024
@dependabot dependabot bot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abergs abergs abergs approved these changes

+1 more reviewer

@joegoldman2 joegoldman2 joegoldman2 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iamcarbon @codecov-commenter @abergs @joegoldman2