KEMBAR78
Added authenticatorDisplayName to ClientPropertiesOutput by aritma-fredrikef · Pull Request #526 · passwordless-lib/fido2-net-lib · GitHub
Skip to content

Conversation

@aritma-fredrikef
Copy link
Contributor

Based on the current editors draft on https://w3c.github.io/webauthn/ a new field authenticatorDisplayName has been added: https://w3c.github.io/webauthn/#dom-credentialpropertiesoutput-authenticatordisplayname

Thought it would be feasible to add this field, since it provides valuable information :)

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.46%. Comparing base (85987ea) to head (e337f98).

Files Patch % Lines
...Fido2.Models/Objects/CredentialPropertiesOutput.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
- Coverage   74.49%   74.46%   -0.03%     
==========================================
  Files          98       98              
  Lines        2639     2640       +1     
  Branches      446      446              
==========================================
  Hits         1966     1966              
- Misses        570      571       +1     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aritma-fredrikef
Copy link
Contributor Author

@dotnet-policy-service agree company="Aritma"

@abergs abergs self-requested a review July 11, 2024 11:56
Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants