Remove base-class, Status and ErrorMessage #529
Conversation
|
@aseigler @iamcarbon I would appreciate your input here in case I've missed anything important. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 74.04% 73.95% -0.10%
==========================================
Files 100 98 -2
Lines 2655 2638 -17
Branches 446 446
==========================================
- Hits 1966 1951 -15
+ Misses 588 586 -2
Partials 101 101 ☔ View full report in Codecov by Sentry. |
|
@abergs I had also explored removing the base class during the initial refactoring (they were mixing concerns) -- and agree this is a good time to take the break and move these values to the endpoints. |
|
Alright, I was able to run the conformance tests on this branch and it went fine. Will merge once tests are OK. |
3 participants
This PR removes the Fido2ResponseBase-class, which had two fields:
StatusErrorMessageThese were never used by the library, only in demoes/samples.
If I recall correctly the reason for these fields are the conformance test tool which looks for them. As such, they should be added in the endpoints that we test against, and not used in the library itself since all errors are handled by throwing exceptions anyway.
Note: This PR is bases for discussion.