Supporting attestation formats #530
Merged
+68
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 15, 2024 18:00
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
==========================================
+ Coverage 73.95% 74.67% +0.72%
==========================================
Files 98 104 +6
Lines 2638 2966 +328
Branches 446 532 +86
==========================================
+ Hits 1951 2215 +264
- Misses 586 634 +48
- Partials 101 117 +16 ☔ View full report in Codecov by Sentry. |
iamcarbon
reviewed
Jul 17, 2024
Src/Fido2.Models/Objects/AuthenticationExtensionsDevicePublicKeyInputs.cs
Show resolved
Hide resolved
added 2 commits
July 17, 2024 08:57
jonashendrickx
changed the title
Assertion time attestation is removed from per this PR: https://github.com/w3c/webauthn/pull/1997/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for attestation formats.
The RP can use this optional member to specify a preference regarding the attestation statement format used by the authenticator. Values SHOULD be taken from the IANA "WebAuthn Attestation Statement Format Identifiers" registry [IANA-WebAuthn-Registries] established by [RFC8809]. Values are ordered from most preferable to least preferable. This parameter is advisory and the authenticator MAY use an attestation statement not enumerated in this parameter.