Fix Cygwin build #108
Merged
Fix Cygwin build #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was very helpful. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, building
poacusing CMake on Cygwin is failed because:UNIX AND NOT APPLEis evaluated as true, thenCYGWINcheck doesn't workUNIX AND CYGWIN AND NOT APPLE AND NOT WIN32is evaluated as true.This PR fixes these problems.
When this PR will be merged (into
appveyorbranch) and you will merge theappveyorbranch intomaster, you should close #93 (because the build on Cygwin is succeeded at ea7715b. When the build will be failed in the future, let's reopen the issue).