KEMBAR78
Fix `.gitignore` generated with poac create by wx257osn2 · Pull Request #660 · cabinpkg/cabin · GitHub
Skip to content

Conversation

wx257osn2
Copy link
Contributor

Current poac outputs poac_output , not target . However, poac create outputs .gitignore for target , so this PR fixes this.

@wx257osn2 wx257osn2 requested a review from ken-matsui July 23, 2022 22:43
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking your time!

@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #660 (b1555ed) into main (ecdd336) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          52       52           
  Lines        2502     2502           
=======================================
  Hits         2456     2456           
  Misses         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdd336...b1555ed. Read the comment docs.

@ken-matsui ken-matsui changed the title fix .gitignore generated with poac create Fix .gitignore generated with poac create Jul 23, 2022
@ken-matsui ken-matsui enabled auto-merge (squash) July 23, 2022 23:27
@ken-matsui ken-matsui disabled auto-merge July 23, 2022 23:27
@ken-matsui ken-matsui enabled auto-merge (squash) July 23, 2022 23:28
@ken-matsui ken-matsui merged commit 8c761fd into main Jul 23, 2022
@ken-matsui ken-matsui deleted the fix-create-gitignore branch July 23, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants