Add --profile Option #661
Merged
Add --profile Option #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 98.16% 98.17% +0.01%
==========================================
Files 52 52
Lines 2502 2527 +25
==========================================
+ Hits 2456 2481 +25
Misses 46 46
Continue to review full report at Codecov.
|
wx257osn2
force-pushed
the
profile-option
branch
from
93694fa to
ae058de
Compare
ken-matsui
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--profileoption tobuildandrunsubcommands.Consideration
cargohas some default profiles, and one of that for developing nameddevoutputstarget/debug/*.In this PR I named
debugfor that, but if you mind, it's better to change before merge.FAQ
valid_profilereturnResult<Option<String>, String>,Result<core::builder::ninja::build::Mode, String>or something like that?poacis aspiring to be likecargo,poacwill support user-defined profiles.Result<String, String>with return value"debug"ifvalid_profile(None, false)orvalid_profile(None, None)?cleansubcommand.cleanneeds to recognize unspecified ,--profile=debug, and release mode (--profile=releaseand/or--release).Nonereturned byvalid_profileindicates above unspecified .