Mobkoi Adapter: bug: getUserSyncs no need to check gdprConsent #13599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeye
changed the title
|
@zeeye this is failing tests can you fix when you get a chance? |
|
also, it appears your id module has a potential memory leak, as it never cleans up its listeners |
zeeye
force-pushed
the
get-user-sync-bug-fixes
branch
from
369e631 to
71141ca
Compare
|
@patmmccann @ChrisHuie Sorry for the delay. I’ve fixed the tests and added code to clean up the event listener after it’s used. |
patmmccann
reviewed
Jul 22, 2025
patmmccann
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Other information