Nexverse Bid Adapter: bug fixes #13644
Conversation
| import { getDeviceModel, buildEndpointUrl, isBidRequestValid, parseNativeResponse, printLog, getUid, getBidFloor, getOsInfo } from '../libraries/nexverseUtils/index.js'; | ||
| import {getStorageManager} from '../src/storageManager.js'; | ||
| import {MODULE_TYPE_UID} from '../src/activities/modules.js'; | ||
| import { getOsVersion } from '../libraries/advangUtils/index.js'; |
There was a problem hiding this comment.
what was incorrect in this one? why not just fix it?
There was a problem hiding this comment.
We were using another adapter's getOsVersion() method and assigning its value to the ORTB osv field. However, getOsVersion() was returning the OS name instead of the version, and getOs() was returning an enum rather than the actual OS name. As a result, ORTB parsing was failing with our newly updated stack — hence the fix.
There was a problem hiding this comment.
hope it is not blocker
There was a problem hiding this comment.
Wouldn't that also be a problem for anyone else using the function?
|
i did latest master pull and now test cases are failing |
…rebid.js into mitesh/nexverse-bug-fix
|
Hi @patmmccann – We’d really appreciate it if you could review this today. It’s a major business blocker for us, and we’ve been stuck on it for a few weeks now. Hope you can help us move forward. |
4 participants
Type of change
Description of change
This pull request updates the Nexverse Bid Adapter with the following enhancements and fixes:
All changes include appropriate test coverage and validation with the
hello_world.htmlpage.Other information
Adapter Maintainer: [anand.kumar@nexverse.ai]