KEMBAR78
Multiple modules: remove GVL IDs that are missing or marked as deleted in the GVL by dgirardi · Pull Request #13647 · prebid/Prebid.js · GitHub
Skip to content

Multiple modules: remove GVL IDs that are missing or marked as deleted in the GVL #13647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 23, 2025
Merged

Multiple modules: remove GVL IDs that are missing or marked as deleted in the GVL #13647

merged 5 commits into from
Jul 23, 2025

Conversation

dgirardi
Copy link
Collaborator

Type of change

  • Build related changes

Description of change

This updates the update-metadata build task to check that GVL IDs provided by modules are present and not marked as deleted in the GVL;

this produced the following list of invalid GVL IDs, which were removed:

"bidder.aidem" provides a GVL ID that is deleted or missing: 1218                                                                                                                             
"bidder.ampliffy" provides a GVL ID that is deleted or missing: 1258                                                                                                                          
"bidder.beachfront" provides a GVL ID that is deleted or missing: 335                                                                                                                         
"bidder.cadent_aperture_mx" provides a GVL ID that is deleted or missing: 183                                                                                                                 
"bidder.ccx" provides a GVL ID that is deleted or missing: 773                                                                                                                                
"bidder.innity" provides a GVL ID that is deleted or missing: 535                                                                                                                             
"bidder.lucead" provides a GVL ID that is deleted or missing: 1309                                                                                                                            
"bidder.mobilefuse" provides a GVL ID that is deleted or missing: 909                                                                                                                         
"bidder.pwbid" provides a GVL ID that is deleted or missing: 842                                                                                                                              
"bidder.qt" provides a GVL ID that is deleted or missing: 1331                                                                                                                                
"bidder.retailspot" provides a GVL ID that is deleted or missing: 1319                                                                                                                        
"bidder.scattered" provides a GVL ID that is deleted or missing: 1179                                                                                                                         
"bidder.slimcut" provides a GVL ID that is deleted or missing: 102                                                                                                                            
"bidder.scm" provides a GVL ID that is deleted or missing: 102
"bidder.talkads" provides a GVL ID that is deleted or missing: 1074
"bidder.ucfunnel" provides a GVL ID that is deleted or missing: 607
"bidder.videoreach" provides a GVL ID that is deleted or missing: 547
"bidder.viewdeosDX" provides a GVL ID that is deleted or missing: 924
"bidder.yieldlift" provides a GVL ID that is deleted or missing: 866
"rtd.rayn" provides a GVL ID that is deleted or missing: 1220

Other information

Closes #13606

@dgirardi dgirardi changed the title Multiple module: remove GVL IDs that are missing or marked as deleted in the GVL Multiple modules: remove GVL IDs that are missing or marked as deleted in the GVL Jul 22, 2025
@github-actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

dgirardi
dgirardi commented Jul 22, 2025
View reviewed changes
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 16449244766

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 66 unchanged lines in 5 files lost coverage.
  • Overall coverage remained the same at 96.256%
Files with Coverage Reduction New Missed Lines %
modules/exadsBidAdapter.js 2 86.63%
modules/mobkoiIdSystem.js 2 77.59%
test/spec/modules/geolocationRtdProvider_spec.js 2 96.67%
src/adapterManager.ts 6 95.37%
modules/pubmaticBidAdapter.js 54 75.69%
Totals Coverage Status
Change from base Build 16446452813: 0.0%
Covered Lines: 194272
Relevant Lines: 201828
💛 - Coveralls

patmmccann
patmmccann reviewed Jul 22, 2025
View reviewed changes
@github-actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann patmmccann merged commit f019cb2 into master Jul 23, 2025
13 of 14 checks passed
@patmmccann patmmccann deleted the gvl-deletion branch July 23, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle GVL deleted entities

3 participants

@dgirardi @coveralls @patmmccann