KEMBAR78
Adform Bid Adapter: ortb2Imp extension by a-sto · Pull Request #13650 · prebid/Prebid.js · GitHub
Skip to content

Conversation

@a-sto
Copy link
Contributor

@a-sto a-sto commented Jul 23, 2025

Type of change

  • Feature

Description of change

Pass full imp[].ext to requests

Contact email: a.stolarz@adform.com

@github-actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann
Copy link
Collaborator

We stopped supporting the getconfig app and site pattern in prebid 8 or 9, removing that solves your duplication alert

@github-actions
Copy link

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

  • modules/adfBidAdapter.js (+2 errors)

@a-sto a-sto force-pushed the imp-ext branch 2 times, most recently from 743fea9 to b5abf8b Compare July 25, 2025 08:01
@a-sto
Copy link
Contributor Author

a-sto commented Jul 25, 2025

We stopped supporting the getconfig app and site pattern in prebid 8 or 9, removing that solves your duplication alert

Ok, removed it

@patmmccann patmmccann merged commit cd9e487 into prebid:master Jul 25, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants