KEMBAR78
Debugging: remove all imports by dgirardi · Pull Request #13665 · prebid/Prebid.js · GitHub
Skip to content

Debugging: remove all imports #13665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 6, 2025
Merged

Debugging: remove all imports #13665

merged 5 commits into from
Aug 6, 2025

Conversation

dgirardi
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

The debugging module, when loaded dynamically, now manages to include an entire second copy of prebid core. This removes all imports from core and adds a linter rule to hopefully prevent this problem from happening again.

@github-actions
Copy link

Tread carefully! This PR adds 8 linter errors (possibly disabled through directives):

  • modules/debugging/index.js (+8 errors)

@coveralls
Copy link
Collaborator

coveralls commented Jul 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16651844794

Details

  • 131 of 162 (80.86%) changed or added relevant lines in 7 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 96.243%
Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/debugging/bidInterceptor.js 97 104 93.27%
modules/debugging/responses.js 6 30 20.0%
Files with Coverage Reduction New Missed Lines %
modules/eskimiBidAdapter.js 1 75.86%
test/spec/modules/paapi_spec.js 3 98.7%
Totals Coverage Status
Change from base Build 16650360615: 0.0%
Covered Lines: 195251
Relevant Lines: 202873
💛 - Coveralls

@patmmccann patmmccann requested a review from mkomorski July 24, 2025 18:08
@github-actions
Copy link

Tread carefully! This PR adds 9 linter errors (possibly disabled through directives):

  • modules/debugging/index.js (+8 errors)
  • modules/debugging/responses.js (+1 error)

@github-actions
Copy link

Tread carefully! This PR adds 9 linter errors (possibly disabled through directives):

  • modules/debugging/index.js (+8 errors)
  • modules/debugging/responses.js (+1 error)

@github-actions
Copy link

Tread carefully! This PR adds 8 linter errors (possibly disabled through directives):

  • modules/debugging/index.js (+8 errors)

@patmmccann patmmccann merged commit 79b435e into master Aug 6, 2025
20 checks passed
@patmmccann patmmccann deleted the fix-standalone-debugging branch August 6, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkomorski mkomorski mkomorski approved these changes

Assignees

@mkomorski mkomorski

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgirardi @coveralls @mkomorski @patmmccann