33Across Bid Adapter: Start using ORTB converter + refactoring #13666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow video ad pod params
Relocate ext attributes
…rtb2_config_attrs
…fig_attrs 33across adapter allow ortb2 config attrs
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
carlosfelix
force-pushed
the
ortb-converter-33across-bid-adapter
branch
from
9f7fa26 to
18a012c
Compare
patmmccann
reviewed
Jul 24, 2025
carlosfelix
force-pushed
the
ortb-converter-33across-bid-adapter
branch
from
73df9fe to
96e56bc
Compare
| }, | ||
| id: 'r1', | ||
| regs: { | ||
| coppa: 0, |
There was a problem hiding this comment.
So where does the coppa value come from in a normal bid-request operation? I don't see it explicitly referenced in the bid adapter implementation. Does it get pulled in with getTTXConfig()?
There was a problem hiding this comment.
I think you are looking into a specific commit diff. Final diff doesn't mention coppa on this location since it's no longer referenced from the adapter and it's being picked from the ORTB converter instead.
There was a problem hiding this comment.
Ah, OK - I see now. Thanks.
|
LGTM |
jefftmahoney
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Start using the ORTB converter utility while going through the process of removing attributes that are no longer needed by 33across. Apply some refactoring to existing functionality.