KEMBAR78
appnexus bid adapter - update logic for native trkjs script detection by jsnellbaker · Pull Request #13677 · prebid/Prebid.js · GitHub
Skip to content

appnexus bid adapter - update logic for native trkjs script detection #13677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

appnexus bid adapter - update logic for native trkjs script detection #13677

merged 1 commit into from
Jul 25, 2025

Conversation

jsnellbaker
Copy link
Collaborator

@jsnellbaker jsnellbaker commented Jul 25, 2025 •
edited
Loading

Type of change

  • Updated bidder adapter

Description of change

Small change to alter how we detect the trk.js script for native bids; to support different scripts that can return.

@jsnellbaker jsnellbaker requested a review from Fawke July 25, 2025 13:45
@patmmccann patmmccann changed the title appnexus bid adapter - update logic for trkjs script detection appnexus bid adapter - update logic for native trkjs script detection Jul 25, 2025
Fawke
Fawke approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit 00ca66f into master Jul 25, 2025
32 of 35 checks passed
@jsnellbaker jsnellbaker deleted the appnexus_trkjs_checks branch July 25, 2025 15:36
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 16523506076

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 60 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+33.1%) to 96.267%
Files with Coverage Reduction New Missed Lines %
src/adloader.js 12 78.57%
src/utils.js 48 88.84%
Totals Coverage Status
Change from base Build #3: 33.1%
Covered Lines: 194822
Relevant Lines: 202376
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fawke Fawke Fawke approved these changes

Assignees

@Fawke Fawke

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsnellbaker @coveralls @Fawke