Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
• modules/omsBidAdapter.js has 29 duplicated lines with modules/onomagicBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

-please fix yourself and onomagic to import all of these functions from a shared library

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
• modules/omsBidAdapter.js has 25 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann Hi, thanks for you comment!

Done, small note:

getMinSize - I found the same code in 3 more adapters: 33across, marsmedia and medianet, I replaced it for them as well.
isIframe - the same: 33across, valuad and underdogmedia

Please, let me know if you see any other problems, thanks a lot!

thanks!