KEMBAR78
Test suite: clean up tests not setting shouldClearNativeTimers by patmmccann · Pull Request #13689 · prebid/Prebid.js · GitHub
Skip to content

Conversation

@patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented Jul 29, 2025

removes some test suite noise after #13288

@patmmccann patmmccann changed the title Test suite: clean up tests using real timers Test suite: clean up tests not setting shouldClearNativeTimers Jul 29, 2025
@dgirardi
Copy link
Collaborator

I still see the warning in the output (for example here).

I think tracking all of them down is likely to be difficult, what's probably happening is some test not interested in timers causes some to be created, then cleared later when some other unrelated test has set up fake timers. I don't want to add the flag everywhere because the warning can actually be useful when running tests in isolation, and it seems unfair to force good tests to suppress it to accommodate bad tests.

@patmmccann
Copy link
Collaborator Author

Yeah I wasn't attempting to fix them all in one shot; do you think we should suppress the warning? It's definitely making the output a bit annoying. Or we could force it to be set in tsst_deps. These tests in particular seem to not be clearing their timers in their after() and my understanding is this option just makes it so that happens without the explicit clear later?

@ChrisHuie ChrisHuie self-assigned this Jul 31, 2025
@ChrisHuie ChrisHuie merged commit 187a774 into prebid:master Jul 31, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants