KEMBAR78
topicsFpdModule: require enrichUfpd for loading topics iframes by dgirardi · Pull Request #13710 · prebid/Prebid.js · GitHub
Skip to content

topicsFpdModule: require enrichUfpd for loading topics iframes #13710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 14, 2025
Merged

topicsFpdModule: require enrichUfpd for loading topics iframes #13710

merged 5 commits into from
Aug 14, 2025

Conversation

dgirardi
Copy link
Collaborator

@dgirardi dgirardi commented Jul 31, 2025 •
edited
Loading

Type of change

  • Bugfix

Description of change

Require enrichUfpd before loading topics iframes (and not just before enriching requests).

@coveralls
Copy link
Collaborator

coveralls commented Jul 31, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16969157831

Details

  • 50 of 51 (98.04%) changed or added relevant lines in 2 files are covered.
  • 59 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+33.1%) to 96.251%
Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/topicsFpdModule.js 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
src/adloader.js 12 78.57%
src/utils.js 47 89.07%
Totals Coverage Status
Change from base Build #3: 33.1%
Covered Lines: 195444
Relevant Lines: 203056
💛 - Coveralls

@patmmccann patmmccann self-requested a review August 1, 2025 14:36
@patmmccann patmmccann self-assigned this Aug 1, 2025
@patmmccann
Copy link
Collaborator

Note that this means that the bidder associated with the iframe needs its bidderSettings storageAllowed to be enabled, which is arguably breaking.

This would certainly break us; let's chat about alternatives

@dgirardi dgirardi changed the title topicsFpdModule: require accessDevice for loading topics iframes topicsFpdModule: require enrichUfpd for loading topics iframes Aug 14, 2025
@patmmccann patmmccann merged commit 95eee3c into master Aug 14, 2025
20 checks passed
@patmmccann patmmccann deleted the topics-consent branch August 14, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels

needs update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgirardi @coveralls @patmmccann