KEMBAR78
Bidfuse Bid Adapter : initial release by bidfuse · Pull Request #13783 · prebid/Prebid.js · GitHub
Skip to content

Bidfuse Bid Adapter : initial release #13783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 12, 2025
Merged

Bidfuse Bid Adapter : initial release #13783

merged 11 commits into from
Sep 12, 2025

Conversation

bidfuse
Copy link
Contributor

@bidfuse bidfuse commented Aug 19, 2025

Type of change

  • New bidder adapter

Other information

Doc MR - prebid/prebid.github.io#6221

@bidfuse bidfuse mentioned this pull request Aug 19, 2025
Open
2 tasks
@ChrisHuie ChrisHuie requested a review from osazos August 19, 2025 18:11
@ChrisHuie ChrisHuie changed the title init new adapter Bidfuse Bidfuse Bid Adapter : initial release Aug 19, 2025
@osazos
Copy link
Collaborator

osazos commented Aug 20, 2025 •
edited
Loading

Hi @bidfuse

Here are my first comments:

  • Please fix your tests.
    [x] You chose bidfuseprebid as the bidder code. This is not common and the "prebid" suffix seems useless. Could it be removed?
    [x] The example in your .md file includes a lot of options that are not documented. Is this intentional?
    [x] In your doc, it says "For the prebid server and prebid.js you […]", but you set pbs: false.

@osazos
Copy link
Collaborator

osazos commented Aug 20, 2025

Also, I got an error with the sync url:

GET https://syncbf.bidfuse.com/image?pbjs=1&coppa=0 net::ERR_CONNECTION_REFUSED

@bidfuse
Copy link
Contributor Author

bidfuse commented Aug 20, 2025 •
edited
Loading

We are currently unpacking cookie sync server. It will be available soon.

osazos
osazos reviewed Aug 20, 2025
View reviewed changes
@osazos osazos self-requested a review August 20, 2025 09:31
@osazos
Copy link
Collaborator

osazos commented Aug 20, 2025 •
edited
Loading

[x] In your doc, also update the pbs app support flag please: pbs_app_supported: false

@osazos
Copy link
Collaborator

osazos commented Aug 20, 2025

We are currently unpacking cookie sync server. It will be available soon.

I would prefer to release your adapter when the sync is ready. Do you have an ETA?

@bidfuse
Copy link
Contributor Author

bidfuse commented Aug 21, 2025

@osazos CS server started

osazos
osazos approved these changes Aug 26, 2025
View reviewed changes
Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Additionally, not directly related to the PR code itself, but it seems you have an issue with your sync URL https://syncbf.bidfuse.com/image?pbjs=1….
It redirects to https://syncbf.bidfuse.com/42e07a438e71ad07eabd104f7c353355.gif?gdpr=1gdpr_consent=CQ…, but it looks like an & is missing between the two params, which results in a 400 Bad Request.

@osazos
Copy link
Collaborator

osazos commented Sep 1, 2025 •
edited
Loading

Hi @bidfuse any news regarding the sync?

@bidfuse
Copy link
Contributor Author

bidfuse commented Sep 11, 2025

@osazos
fixed
image

@patmmccann patmmccann merged commit 6600bf4 into prebid:master Sep 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osazos osazos osazos approved these changes

Assignees

@osazos osazos

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bidfuse @osazos @patmmccann @ChrisHuie