-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Alvads Bid Adapter : initial release #13799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Implement alvadsBidAdapter module supporting OpenRTB 2.5 POST requests - Supports dynamic endpoints via bid params or default endpoint - Handles banner and video media types with fallback sizes - Parses responses to set mediaType and extract vastXml/vastUrl for video - Includes example test parameters for banner and video - Default netRevenue: true, TTL: 300 - Callback support for onTimeout and onBidWon
…NT/Prebid.js into alvadsBidAdapter
|
Hi, I noticed that the failing tests don’t seem related to this adapter. Could it be that they are flaky in CI (since window.pbjs sometimes shows as undefined)? All unit tests for alvadsBidAdapter are passing locally. Just wanted to check if this is expected or if I should re-run the workflow. |
|
Hi, tests are passing. Waiting for workflow approval from a maintainer. |
…NT/Prebid.js into alvadsBidAdapter
…NT/Prebid.js into alvadsBidAdapter
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Your adapter must support the floors module
Please link your prebid.github.io PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the update.
After reading it again:
- I opened two new threads
- I also missed asking you to move your test file into test/spec/modules/
It should be good after that.
…NT/Prebid.js into alvadsBidAdapter
|
@osazos, thanks for the feedback |
|
LGTM |
alvadsBidAdapter: support OpenRTB 2.5 POST requests with banner & video
Documentation PR: prebid/prebid.github.io#6231
Overview
Module Name: alvadsBidAdapter
Module Type: bidder
Maintainer: alvads@oyealva.com
Type of Change
Description
The Alva Bid Adapter allows publishers to connect their banner and video inventory with the Alva demand platform.
alvadsbanner,videoTest Parameters
Banner Example
Video Example
Request Information
Banner / Video
POSTsite,device,user,regs,imp.Response Information
Banner
The response is standard OpenRTB with
seatbid. Example:{ "id": "response-id", "seatbid": [{ "bid": [{ "impid": "imp-123", "price": 0.50, "adm": "<div>Creative</div>", "crid": "creative-1", "w": 320, "h": 100, "ext": { "vast_url": "http://example.com/vast.xml" }, "adomain": ["example.com"] }] }], "cur": "USD" }Interpretation:
If adm contains , the adapter sets mediaType: 'video' and includes vastXml & vastUrl.
Otherwise, mediaType: 'banner' and ad contains the HTML.
Additional Details
Defaults:
netRevenue = truettl = 300320x1001280x720Callbacks:
onTimeout→ logs timeout eventsonBidWon→ logs winning bid