Core: remove use of document.write in rendering #13851
Merged
+29
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17469486843Details
💛 - Coveralls |
mkomorski
approved these changes
Sep 8, 2025
| e?.stack && logError(e); | ||
| } | ||
| ); | ||
| // TODO: this is almost certainly the wrong way to do this |
robertrmartinez
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This removes the special case for bids providing
ad(and notadUrl) that, when not in a safeframe, are rendered usingdocument.write; replacing it with an iframesrcdocinstead (the same logic used in the safeframe case).From my testing this fixes the GAM viewability issue reported in #13836 without the need to turn off yielding.
Other information
Related: #8337