Advertising Bid Adapter: update parsing bid.impid to support the change to UUID format for bid ids #13879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support the change to UUID format for bid ids
…ingcom-request-response-id-mismatch-bugfix Advertising Bid Adapter: Update the regex while parsing bid.impid to support the change to UUID format for bid ids
|
@patmmccann Any feedback on this? |
ChrisHuie
changed the title
ChrisHuie
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
In Prebid 10.7.0, a change was released that updated how the request bid ids are formed (See #13698)
In advertising.com's bid adapter (
bidderCode: advertising), we have a regex that we use to parse the incomingbid.impid. We do this since we prepend the request bid id byborvin our response to indicate whether the impression is banner or video. The existing regex expected alphanumeric characters to follow after theborvwhich was the case per the previous bid id format. However, with the new UUID based format,-characters are introduced too which breaks thebid.impidparsing.So, an incoming response
bid.impidofb07d74d2f-27ce-4f98-915b-211bc91f7d71would actually be parsed to07d74d2fas opposed to expected07d74d2f-27ce-4f98-915b-211bc91f7d71after correctly stripping offb. This causes a mismatch between bid request id and bid response id and results in our adapter completely breaking since the incoming bids are discarded. Warnings like the following are logged.I have updated the regex to accept everything after 'b' or 'v' and have confirmed that this fixes the issue.
Other information
Related PR: #13698
Since this issue breaks our adapter in versions 10.7.0, 10.8.0, 10.9.0, and 10.10.0, would it be possible to get a patch release for those versions?
I am also considering opening a docs PR once this fix is merged and released to add a note next to our adapter on the download page to flag to publishers that they should avoid using the affected versions.
Let me know your thoughts.