Core: add PUC version in targeting keys #13885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
Pull Request Test Coverage Report for Build 17651753938Details
💛 - Coveralls |
patmmccann
approved these changes
Sep 11, 2025
patmmccann
reviewed
Sep 11, 2025
| UUID: 'hb_uuid', | ||
| CACHE_HOST: 'hb_cache_host' | ||
| CACHE_HOST: 'hb_cache_host', | ||
| VERSION: 'hb_ver' |
There was a problem hiding this comment.
i do not think we'd want this to be a default targeting key if we're not recommending the puc?
patmmccann
requested changes
Sep 11, 2025
|
Including it by default makes it a bit easier to transition away from |
|
that's reasonable, advanced users on the new methods can easily also remove a key they don't want. |
patmmccann
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This adds the
hb_verkey-value to all targeting, controllable withtargetingControls.versionand containing the PUC version to use,so that creatives using PUC can avoid pointing to
@latest(see prebid/prebid-universal-creative#187)Other information
Closes prebid/prebid-universal-creative#187