ID5 Analytics Module : no buffering of events, allow replacing existing rules #13909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hqave you noticed #13842 |
ChrisHuie
changed the title
ChrisHuie
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Buffering of events caused some events to be sent out multiple times, as buffer was never cleared. As events are sent one-by-one, the buffering does not bring much benefits either way, so we removed it to simplify the code.
Introduced flag allowing for replacing of the cleanup rules - sometimes we need more fine grained control over those cleanup rules.