Core: Adding bidLimit to adUnit #13930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18194719118Details
💛 - Coveralls |
dgirardi
reviewed
Oct 1, 2025
src/targeting.ts
Outdated
| // if adUnitBidLimit is set, pass top N number bids | ||
| if (adUnitBidLimit) { | ||
| const adUnit = auctionManager.getAdUnits().find(au => au.code === bucketKey); | ||
| const bidLimit = adUnit?.bidLimit || adUnitBidLimit; |
There was a problem hiding this comment.
there's some logic one level up that says roughly "use the bid limit only if sendAllBids is enabled". With this change that's short circuited when the ad unit bid limit is set, which I don't think we want.
Since there you also know all ad units involved it makes sense IMO to calculate the bid limit per adunit there, which lets you loop through them one time instead of once per ad unit. For example the adUnitBidLimit parameter passed into here could be made into a map.
dgirardi
reviewed
Oct 2, 2025
src/targeting.ts
Outdated
| if (!config.getConfig('enableSendAllBids')) return 0; | ||
| const bidLimitConfigValue = config.getConfig('sendBidsControl.bidLimit'); | ||
| return adUnitCodes.reduce((acc, code) => { | ||
| const adUnit = auctionManager.getAdUnits().find(au => au.code === code); |
There was a problem hiding this comment.
this is still O(N^2), which is unnecessary. one single loop over getAdUnits() is enough to find those you're interested in.
mkomorski
force-pushed
the
mkomorski/bids-limit-on-adunit
branch
from
1053eeb to
476bcbd
Compare
dgirardi
approved these changes
Oct 2, 2025
patmmccann
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
#9842