KEMBAR78
Core: isolate DNT helper by patmmccann · Pull Request #13940 · prebid/Prebid.js · GitHub
Skip to content

Conversation

patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented Sep 26, 2025

Attempts to consolidate use of DNT detection into one place. Related: #12060

@github-actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, the new util is a bit verbose but that's fine with it now an optional import

@patmmccann patmmccann merged commit b795035 into prebid:master Oct 3, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants