EmpowerBidAdapter: initial release #13943
Conversation
|
Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):
|
There was a problem hiding this comment.
Hi @ferrerodbgm, I’ve done a high-level review so far and wanted to share a few pointers.
- If your endpoint supports ORTB Request/Response, you can use
ortbConverterto save a lot of duplicate effort in your adapter. You can still add your custom changes on top of that. - Also, why not use TypeScript?
|
Hi @monis0395, We have created this script for some other enviroments. That's why we do not want to use Prebid specific oRTB utils. We simply adopted here. This was more effortless for us. Second questions answer is very related with the first one. JS is more useful for us. Thanks. |
|
Hi @monis0395, Is there any update about review? Is there any problem about adapter? Thanks. Have a nice day. |
|
Hi @monis0395, Can we get a review please. Thanks. |
|
Also while the documentation says schain is supported, I dont see schain being consumed from |
|
Hi @monis0395, We added some test cases, and changed our code according to your reviews. Can you please review again? Thanks. |
3 participants
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information