KEMBAR78
Msft Bid adapter - initial release (for closed testing) by jsnellbaker · Pull Request #13952 · prebid/Prebid.js · GitHub
Skip to content

Conversation

@jsnellbaker
Copy link
Collaborator

@jsnellbaker jsnellbaker commented Sep 30, 2025

Type of change

  • New bidder adapter

Description of change

{
  bidder: 'msft',
  params: {
    placement_id: 13144370 // banner
    placement_id: 33911093 // video outstream
    placement_id: 31523633 // video instream
    placement_id: 33907873 // native
  }
}

Other information

This adapter should eventually replace the appnexus bid adapter, but that will take a long time in reality so we're not removing the appnexus adapter at this time.

The adapter uses a new openrtb endpoint instead of the previous UT endpoint. As a result, the new adapter uses the ortb converter feature to largely manage the creation/handling the request and bid response.

There are a number of bid params from the appnexus adapter that are 'deprecated' as bid params in the msft adapter. These params however are just sourcing the information from other parts of Prebid setup (like first party data or the adUnit.mediaTypes).

@github-actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/msftBidAdapter.js (+1 error)

1 similar comment
@github-actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/msftBidAdapter.js (+1 error)

@github-actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/msftBidAdapter.js (+1 error)

@coveralls
Copy link
Collaborator

coveralls commented Sep 30, 2025

Pull Request Test Coverage Report for Build 18167401210

Details

  • 284 of 315 (90.16%) changed or added relevant lines in 2 files are covered.
  • 57 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+33.1%) to 96.235%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/msftBidAdapter.js 142 173 82.08%
Files with Coverage Reduction New Missed Lines %
src/adloader.js 12 78.57%
src/utils.js 45 88.84%
Totals Coverage Status
Change from base Build #3: 33.1%
Covered Lines: 198799
Relevant Lines: 206577

💛 - Coveralls

@jsnellbaker jsnellbaker marked this pull request as ready for review October 7, 2025 15:06
@patmmccann patmmccann requested a review from dgirardi October 7, 2025 21:02
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgirardi please do a second look?

@jsnellbaker jsnellbaker changed the title Msft adapter Msft Bid adapter - initial release (for closed testing) Oct 8, 2025
@jsnellbaker
Copy link
Collaborator Author

@dgirardi made a series of changes per feedback. Still awaiting word on the eids question.

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/msftBidAdapter.js (+1 error)

@jsnellbaker jsnellbaker merged commit ee900eb into master Oct 14, 2025
30 of 34 checks passed
@jsnellbaker jsnellbaker deleted the msft_adapter branch October 14, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants