-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Msft Bid adapter - initial release (for closed testing) #13952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
1 similar comment
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
Pull Request Test Coverage Report for Build 18167401210Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgirardi please do a second look?
|
@dgirardi made a series of changes per feedback. Still awaiting word on the eids question. |
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
Type of change
Description of change
Other information
This adapter should eventually replace the appnexus bid adapter, but that will take a long time in reality so we're not removing the appnexus adapter at this time.
The adapter uses a new openrtb endpoint instead of the previous UT endpoint. As a result, the new adapter uses the ortb converter feature to largely manage the creation/handling the request and bid response.
There are a number of bid params from the appnexus adapter that are 'deprecated' as bid params in the msft adapter. These params however are just sourcing the information from other parts of Prebid setup (like first party data or the
adUnit.mediaTypes).