KEMBAR78
ADBRO Bid Adapter : Initial Release by inebritov · Pull Request #13963 · prebid/Prebid.js · GitHub
Skip to content

ADBRO Bid Adapter : Initial Release #13963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 2, 2025
Merged

ADBRO Bid Adapter : Initial Release #13963

merged 20 commits into from
Oct 2, 2025

Conversation

inebritov
Copy link
Contributor

@inebritov inebritov commented Oct 2, 2025 •
edited
Loading

Type of change

  • New bidder adapter

Description of change

  • Contact email of the adapter’s maintainer: devops@adbro.me
  • Test parameters for validating bids:
{
    bidder: 'adbro',
    params: {
        placementId: '1234'
    }
}

inebritov and others added 20 commits September 3, 2025 17:33
@inebritov
Implemented minimal working ADBRO Bid Adapter
08656df 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@ashvetsov
Added ADBRO Bid Adapter description with Test Parameters.
d4aa4e6 
ADBRO-4285

Signed-off-by: Alexander Shvetsov <ashvetsov@adbro.me>
@inebritov
Added setting up sizes and display manager fields in banner object
968ded0 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Building TagId using GPID
7d17147 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Added ADBRO bill notification
c4a6e33 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Removed excess params, imports and checks
57d37f2 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Explicitly cast request validity condition to Boolean
6a9f76e 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Iterate all requests in buildRequests
cc51641 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Group imps by Placement ID to send a single request per placement
cebcca5 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Change default and fallback tagid
9d1aefa 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Changed billing event to onBidBillable
585af89 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Fixed failing fallback tagid
60b9124 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
ADBRO Bid Adapter is covered with tests
60931b0 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Set Creative Id from the test config on backend
9cf63ab 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Added Bid Response bids existence check
2b4ded1 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Review fixes
d43e6a3 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Raised default impression expire timeout to 300 sec
17d4098 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Null-checks are moved out from the isBidRequestValid function
41a3982 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Covered null cases in isBidRequestValid function
2fc1edf 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov
Replaced testing domain with the prod one
2f31911 
ADBRO-4285

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@ashvetsov ashvetsov mentioned this pull request Oct 2, 2025
Open
3 tasks
@patmmccann patmmccann merged commit 0af0189 into prebid:master Oct 2, 2025
17 of 21 checks passed
@inebritov
Copy link
Contributor Author

The fastest merge in the Wild West. Hard to believe it got merged in just one day. @patmmccann are you sure everything is correct?

@patmmccann
Copy link
Collaborator

@inebritov honestly it looks pretty boiler plate; we've spent a bunch of time simplifying the adapter template and you followed it quite closely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patmmccann patmmccann patmmccann approved these changes

@jefftmahoney jefftmahoney Awaiting requested review from jefftmahoney

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inebritov @patmmccann @ashvetsov