KEMBAR78
Build system: start browserstack binary explicitly by dgirardi · Pull Request #13999 · prebid/Prebid.js · GitHub
Skip to content

Conversation

dgirardi
Copy link
Collaborator

@dgirardi dgirardi commented Oct 9, 2025

Type of change

  • Build related changes

Description of change

A number of test failures are due to browserstack not being able to connect to the box running the tests (e.g. https://github.com/prebid/Prebid.js/actions/runs/18377485917/job/52355196052?pr=13991)

This starts the browserstack tunnel explicitly to see if it makes a difference.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 18451057343

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 57 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+33.1%) to 96.238%

Files with Coverage Reduction New Missed Lines %
src/adloader.js 12 78.57%
src/utils.js 45 88.81%
Totals Coverage Status
Change from base Build #3: 33.1%
Covered Lines: 199064
Relevant Lines: 206845

💛 - Coveralls

Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patmmccann patmmccann merged commit 05e5e99 into master Oct 13, 2025
20 checks passed
@patmmccann patmmccann deleted the explicit-browserstack-local branch October 13, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants