KEMBAR78
Add Exemplars support for all time series by jonatan-ivanov · Pull Request #11984 · prometheus/prometheus · GitHub
Skip to content

Conversation

jonatan-ivanov
Copy link
Contributor

fixes #11982

Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code seems ok; couple of queries about changes to tests.

@jonatan-ivanov jonatan-ivanov force-pushed the exemplars-for-all-time-series branch from bf6f342 to 7bd45f2 Compare March 4, 2023 01:08
This change removes restrictions to allow adding exemplars
to all time series. It also contains some improvements in test values
so that it is easier to track what is tested.
The advantage of doing this is having a little less error-prone tests:
"yy" is not really descriptive but "counter-test" can give people
a better idea about what is tested so it is harder to make mistakes.

Closes prometheusgh-11982

Signed-off-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>
@jonatan-ivanov jonatan-ivanov force-pushed the exemplars-for-all-time-series branch from 7bd45f2 to 9225d11 Compare March 4, 2023 01:09
@roidelapluie roidelapluie merged commit aeb44cd into prometheus:main Mar 5, 2023
@roidelapluie
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exemplars support for all time series

3 participants