KEMBAR78
Comparing v1.36.2...v1.36.3 · protocolbuffers/protobuf-go · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: protocolbuffers/protobuf-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.36.2
Choose a base ref
...
head repository: protocolbuffers/protobuf-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.36.3
Choose a head ref
  • 11 commits
  • 51 files changed
  • 1 contributor

Commits on Jan 7, 2025

  1. all: start v1.36.2-devel

    Change-Id: I0dd6425a197595757db28fbdd84f81f048a5ef36
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/641016
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    stapelberg committed Jan 7, 2025
    Configuration menu
    Copy the full SHA
    ad89419 View commit details
    Browse the repository at this point in the history
  2. types/dynamicpb: switch atomicExtFiles to atomic.Uint64 type

    (Go Protobuf currently requires Go 1.21.)
    
    This guarantees correct alignment on stack-allocated values, too.
    
    Change-Id: If713532c20326a7ee3f1dd5c77f49c1d52f6eb9a
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/641017
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    stapelberg committed Jan 7, 2025
    Configuration menu
    Copy the full SHA
    9acc8f2 View commit details
    Browse the repository at this point in the history
  3. internal/impl: clean up unneeded Go<1.12 MapRange() alternative

    (Go Protobuf currently requires Go 1.21.)
    
    Change-Id: Ib851304af2efe9845df260b700fcd577a375d3a8
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/641035
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    stapelberg committed Jan 7, 2025
    Configuration menu
    Copy the full SHA
    84f7738 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2025

  1. cmd/protoc-gen-go: remove json struct tags from unexported fields

    This commit does not change behavior because the encoding/json
    package ignores unexported fields. To encode a Protobuf message
    into JSON, users should reach for protobuf/encoding/protojson.
    
    With this change, the generated code (.pb.go files) passes go vet.
    I also made the integration test run go vet so that we do not regress.
    
    For golang/protobuf#1657
    
    Fixes golang/protobuf#1658
    
    Change-Id: I0a677d09e4517b2649bfcfe76a49194c7ccbb823
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/641036
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    stapelberg committed Jan 8, 2025
    Configuration menu
    Copy the full SHA
    fe8430d View commit details
    Browse the repository at this point in the history
  2. internal/impl: switch to reflect.Value.IsZero

    (Go Protobuf currently requires Go 1.21.)
    
    Change-Id: I5b9f783bbd3611fedc544e1367cc3db9f0123494
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/641018
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    stapelberg committed Jan 8, 2025
    Configuration menu
    Copy the full SHA
    84924f7 View commit details
    Browse the repository at this point in the history
  3. internal/impl: remove unused exporter parameter

    This parameter became unused with golang/protobuf#1640.
    
    Change-Id: Iab50ffb757f5b6f017bc32c37b25294894c1c6d9
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/641019
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    stapelberg committed Jan 8, 2025
    Configuration menu
    Copy the full SHA
    5fee2a7 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2025

  1. all: split flags.ProtoLegacyWeak out of flags.ProtoLegacy

    This is a no-op change in preparation of removing support for weak fields.
    It allows users to keep enabling ProtoLegacy in general,
    but also disable weak field support independently.
    
    For golang/protobuf#1666
    
    Change-Id: Ic3cb90d937e21a817ddbbb36029274be8b5f2513
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/641635
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    stapelberg committed Jan 9, 2025
    Configuration menu
    Copy the full SHA
    42e0fa9 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2025

  1. runtime/protolazy: replace internal doc link with external link

    Change-Id: Ie610db576e89a0ba48082eb375f8cef300236531
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/642015
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Michael Stapelberg <stapelberg@google.com>
    stapelberg authored and gopherbot committed Jan 10, 2025
    Configuration menu
    Copy the full SHA
    de043b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2025

  1. proto: add example for GetExtension, SetExtension

    (Adding an example to HasExtension as well seemed too much to me.)
    
    The example message uses the same example names as the Generated Code Reference:
    https://protobuf.dev/reference/go/go-generated-opaque/#extensions
    
    The definition follows the Language Guide:
    https://protobuf.dev/programming-guides/editions/#extensions
    
    For golang/protobuf#1528
    
    Change-Id: I7c5c4a0ac954678a5e0b10015374377b32bd7634
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/641876
    Reviewed-by: Damien Neil <dneil@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Chressie Himpel <chressie@google.com>
    stapelberg committed Jan 13, 2025
    Configuration menu
    Copy the full SHA
    2f60868 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2025

  1. reflect/protodesc: fix panic when working with dynamicpb

    Thanks to Joshua Humphries and Edward McFarlane for
    the excellent bug report, reproducer and fix suggestion!
    
    Fixes golang/protobuf#1669
    
    Change-Id: I03df76f789e6e11b53396396a1f6b58bb3fb840b
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/642575
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Chressie Himpel <chressie@google.com>
    stapelberg committed Jan 15, 2025
    Configuration menu
    Copy the full SHA
    7cbd915 View commit details
    Browse the repository at this point in the history
  2. all: release v1.36.3

    Change-Id: Icf5049d5341b55c6e2660122e5abae77f571359c
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/642855
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Chressie Himpel <chressie@google.com>
    stapelberg committed Jan 15, 2025
    Configuration menu
    Copy the full SHA
    54ef969 View commit details
    Browse the repository at this point in the history
Loading