KEMBAR78
Comparing v1.36.5...v1.36.6 · protocolbuffers/protobuf-go · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: protocolbuffers/protobuf-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.36.5
Choose a base ref
...
head repository: protocolbuffers/protobuf-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.36.6
Choose a head ref
  • 7 commits
  • 157 files changed
  • 3 contributors

Commits on Feb 6, 2025

  1. all: start v1.36.5-devel

    Change-Id: I68c163ac7ac8fb75e88a5ce8b0c83b3869b54e3e
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/647156
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Chressie Himpel <chressie@google.com>
    stapelberg committed Feb 6, 2025
    Configuration menu
    Copy the full SHA
    1719d63 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2025

  1. all: set Go language version to Go 1.22

    Go 1.24 was released recently.
    
    Change-Id: I4e2c83c6cc90a3c7e996f8e6ba6ee7f8589596ee
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/649135
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    stapelberg committed Feb 13, 2025
    Configuration menu
    Copy the full SHA
    9c8c2dd View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2025

  1. types/descriptorpb: regenerate using latest protobuf v30 release

    The changes to integration_test.go and internal/filedesc/editions.go
    were manual, the rest is the result of ./regenerate.bash.
    
    Note that while Protobuf v30 supports Bazel 8, the targets we need
    ("test and release targets") still require Bazel 7. An easy way
    to work with Bazel 7 is to use bazelisk:
    
    mkdir /tmp/wrap
    cat > /tmp/wrap/bazel <<'EOT'
    USE_BAZEL_VERSION=7.x bazelisk "$@"
    EOT
    chmod +x /tmp/wrap/bazel
    export PATH=/tmp/wrap:$PATH
    ./regenerate.bash
    
    Change-Id: Idfa8d149995025ec5194711ca60648cee50b0766
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/654955
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Chressie Himpel <chressie@google.com>
    stapelberg committed Mar 5, 2025
    Configuration menu
    Copy the full SHA
    f7fcf5b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2025

  1. proto: Add CloneOf[M Message](m M) M

    This allows writing:
      `copy := proto.CloneOf(orig)`
    instead of the previous:
      `copy := proto.Clone(orig).(*pb.MyMessage)`
    
    Fixes golang/protobuf#1594
    
    Change-Id: I7b8b712b6e59607ccc339720ee3c146e8a7ea28b
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/653536
    Reviewed-by: Cassondra Foesch <cfoesch@gmail.com>
    Reviewed-by: Michael Stapelberg <stapelberg@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Jille authored and stapelberg committed Mar 17, 2025
    Configuration menu
    Copy the full SHA
    4247b1b View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2025

  1. internal_gengo: generate a const string literal for the raw descriptor

    Putting the raw descriptor into a const string literal has been
    attempted before (go.dev/cl/638135), but that change has been reverted
    (go.dev/cl/642857) because the generated string contained non-UTF-8
    bytes.
    
    This time we let the %q formatting verb handle the conversion of the
    bytes into a UTF-8-conform string literal.
    
    We also found an interesting way to split the bytes into multiple
    "lines": We use the fact that FileDescriptorProto (and some
    submessages) have a LEN encoded field (string) with field_number=1,
    so splitting at 0x0a (incidentally a newline character in ascii)
    we get a splitting that almost looks readable.
    
    As expected, the const string literals are landing in .rodata.
    
        % (go test -c google.golang.org/protobuf/internal/reflection_test &&
           strings -tx reflection_test.test | grep -F '2&.goproto.proto.testeditions.ImportEnumB' &&
           readelf -SW reflection_test.test | grep -F .rodata)
         321b07 2&.goproto.proto.testeditions.ImportEnumB
           [ 2] .rodata           PROGBITS        000000000065a000 25a000 131fc1 00   A  0   0 32
    
    Change-Id: I77aef7b5032e52c2c485cf662045c9028549fd94
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/657895
    Commit-Queue: Michael Stapelberg <stapelberg@google.com>
    Reviewed-by: Cassondra Foesch <cfoesch@gmail.com>
    Reviewed-by: Nicolas Hillegeer <aktau@google.com>
    Reviewed-by: Michael Stapelberg <stapelberg@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    chressie authored and stapelberg committed Mar 20, 2025
    Configuration menu
    Copy the full SHA
    9f3ed37 View commit details
    Browse the repository at this point in the history
  2. gha-ci: instruct bazelisk to use Bazel 7.x

    I noticed that our GitHub Actions CI started failing recently.
    This change fixes the issue by sticking to Bazel 7.x.
    
    Change-Id: Iab8b27512e526c2b204421b83a87241827c4aad4
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/659495
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    stapelberg committed Mar 20, 2025
    Configuration menu
    Copy the full SHA
    a5da9b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2025

  1. all: release v1.36.6

    Change-Id: I243fc05412297e360b019555fd15176b8bc52ce6
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/660315
    Reviewed-by: Chressie Himpel <chressie@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    stapelberg committed Mar 24, 2025
    Configuration menu
    Copy the full SHA
    3f79c52 View commit details
    Browse the repository at this point in the history
Loading