KEMBAR78
Add ability to run pip with options for yaml tests by ilanschnell · Pull Request #7958 · pypa/pip · GitHub
Skip to content

Add ability to run pip with options for yaml tests #7958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2020
Merged

Add ability to run pip with options for yaml tests #7958

merged 5 commits into from
Apr 9, 2020

Conversation

@ilanschnell
Copy link
Contributor

@ilanschnell ilanschnell commented Apr 2, 2020 •
edited
Loading

This PR adds the ability to run pip with options for the yaml tests, as well as pip uninstall. Also (as discussed with @pradyunsg) a better yaml-syntax was is implemented. For example:

cases:
-
  request:
    - install: A
       options: --no-deps
    - uninstall: A
  response:
    - state:
      - A 1.0.0
    - state: null

Each of the request items (currently install and uninstall) correspond to response items (state). Also, the example illustrates the usage of additional options.

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 2, 2020
@pradyunsg pradyunsg changed the title add ability to run pip with options for yaml tests (work in progress) WIP: add ability to run pip with options for yaml tests Apr 2, 2020
@pradyunsg pradyunsg added C: tests Testing and related things and removed skip news Does not need a NEWS file entry (eg: trivial changes) labels Apr 2, 2020
@pradyunsg
Copy link
Member

@uranusjr I removed the trivial label, so that we don't accidentally merge this in. :)

@pradyunsg pradyunsg changed the title WIP: add ability to run pip with options for yaml tests Add ability to run pip with options for yaml tests Apr 9, 2020
@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 9, 2020
@pradyunsg pradyunsg merged commit c110953 into pypa:master Apr 9, 2020
@ilanschnell ilanschnell deleted the add-yaml-options branch May 14, 2020 04:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees

No one assigned

Labels

C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilanschnell @pradyunsg @uranusjr