tests: assert jinja templates are all rendered correctly. #6765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
reviewed
Oct 5, 2019
tests/functional/test_templates.py
Outdated
Comment on lines
90
to
108
| env.filters.update( | ||
| { | ||
| "format_date": "warehouse.i18n.filters:format_date", | ||
| "format_datetime": "warehouse.i18n.filters:format_datetime", | ||
| "format_rfc822_datetime": "warehouse.i18n.filters:format_rfc822_datetime", | ||
| "format_number": "warehouse.i18n.filters:format_number", | ||
| "format_classifiers": "warehouse.filters:format_classifiers", | ||
| "classifier_id": "warehouse.filters:classifier_id", | ||
| "format_tags": "warehouse.filters:format_tags", | ||
| "json": "warehouse.filters:tojson", | ||
| "camoify": "warehouse.filters:camoify", | ||
| "shorten_number": "warehouse.filters:shorten_number", | ||
| "urlparse": "warehouse.filters:urlparse", | ||
| "contains_valid_uris": "warehouse.filters:contains_valid_uris", | ||
| "format_package_type": "warehouse.filters:format_package_type", | ||
| "parse_version": "warehouse.filters:parse_version", | ||
| "localize_datetime": "warehouse.filters:localize_datetime", | ||
| } | ||
| ) |
There was a problem hiding this comment.
Perhaps we can automatically generate this list?
There was a problem hiding this comment.
It makes sense, would you have any suggestions on how to do that?
There was a problem hiding this comment.
Just bumping, would love to have this merged :)
There was a problem hiding this comment.
Yeah, might be a bit much for this PR. At the very least, can we not duplicate this between the two tests in this file?
There was a problem hiding this comment.
Sure thing, all done!
maiku1008
force-pushed
the
add-unit-test-for-jinja-templates
branch
from
697254c to
e9fd039
Compare
maiku1008
force-pushed
the
add-unit-test-for-jinja-templates
branch
from
e9fd039 to
92f399d
Compare
|
Is there anything else I can improve for this? :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, I added a unit test that should address #6634
I opted to try rendering all templates instead of just the specified one.
Fixes #6634.