Update documentation to discourage virtualenv usage #6784
Conversation
brainwane
changed the title
|
@raghav-ys Please fix the whitespace issue! You can use https://warehouse.readthedocs.io/development/getting-started/#running-tests-and-linters to run the tests locally as you improve your patch. Just so you know, to update this pull request, you don't need to close it and open a new one. You can update your pull request and we recommend you do that (instead of closing the old PR and opening a new one) because then it's easier to see the history of what you've done, to to check that you've responded to previous reviewers' comments, and to preserve links we've mentioned (in comments) with other issues and PRs. |
|
@brainwane whitespace issue is fixed. Appreciate your guidance. |
|
@alanbato or others, could you help get this PR reviewed and finished? I am busy for several weeks. |
| Do not use venv/virtualenv for configuring the development environment. | ||
| Docker creates and remove venv/virtualenv as needed. |
There was a problem hiding this comment.
hello @raghav-ys, thanks for taking the time to improve the docs!
Personally, I would actually prefer the wording of @brainwane mentioned in the original issue #6783, for I find it more developer friendly. Reading a direct "Do not" made me stall a bit 😆
More importantly, the suggested text in the original issue is more accurate, for Docker does not create/remove stuff on its own.
Keep up contributing!
4 participants
Fixes #6783.