KEMBAR78
Support GitHub Issues and drop b.p.o by Mariatta · Pull Request #420 · python/bedevere · GitHub
Skip to content

Support GitHub Issues and drop b.p.o #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2022
Merged

Support GitHub Issues and drop b.p.o #420

merged 3 commits into from
Apr 10, 2022

Conversation

@Mariatta
Copy link
Member

Expect gh- issue number in titles.
Remove logic for adding bpo url in the body.
Validate that the GH- issue is indeed an issue, not PR

Closes #418

@Mariatta
Support GitHub Issues and drop b.p.o
bf6b665 
Expect gh- issue number in titles.
Remove logic for adding bpo url in the body.
Validate that the GH- issue is indeed an issue, not PR

Closes #418
@codecov
Copy link

codecov bot commented Mar 25, 2022 •
edited
Loading

Codecov Report

Merging #420 (d8892fe) into master (2aee86a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d8892fe differs from pull request most recent head cd97d6b. Consider uploading reports for the commit cd97d6b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #420    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           10        20    +10     
  Lines         1300      1689   +389     
==========================================
+ Hits          1300      1689   +389
Impacted Files Coverage Δ
bedevere/__main__.py 100.00% <100.00%> (ø)
bedevere/gh_issue.py 100.00% <100.00%> (ø)
tests/test_gh_issue.py 100.00% <100.00%> (ø)
tests/test_prtype.py 100.00% <0.00%> (ø)
tests/test_filepaths.py 100.00% <0.00%> (ø)
bedevere/news.py 100.00% <0.00%> (ø)
bedevere/close_pr.py 100.00% <0.00%> (ø)
bedevere/stage.py 100.00% <0.00%> (ø)
bedevere/follow_up.py 100.00% <0.00%> (ø)
bedevere/filepaths.py 100.00% <0.00%> (ø)
... and 4 more

@Mariatta Mariatta mentioned this pull request Mar 25, 2022
Closed
@ezio-melotti ezio-melotti requested a review from brettcannon April 7, 2022 20:34
brettcannon
brettcannon approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is mostly a copy-and-paste job from the bpo code.

@ezio-melotti ezio-melotti mentioned this pull request Apr 10, 2022
Open
58 tasks
@ambv ambv merged commit 31d1755 into master Apr 10, 2022
@ambv ambv deleted the use-gh-issues branch April 10, 2022 17:30
@ezio-melotti ezio-melotti mentioned this pull request Apr 12, 2022
Closed
@Mariatta Mariatta mentioned this pull request Apr 12, 2022
Closed
@ezio-melotti ezio-melotti mentioned this pull request Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update bedevere for the GitHub migration

4 participants

@Mariatta @brettcannon @ambv @the-knights-who-say-ni