-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
Closed
Labels
type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Bug report
Bug description:
The docs for PyModule_AddObjectRef say:
Lines 520 to 521 in cae1526
| Return ``NULL`` if *value* is ``NULL``. It must be called with an exception | |
| raised in this case. |
However the function actually returns -1 in that case:
Lines 590 to 597 in cae1526
| if (!value) { | |
| if (!PyErr_Occurred()) { | |
| PyErr_SetString(PyExc_SystemError, | |
| "PyModule_AddObjectRef() must be called " | |
| "with an exception raised if value is NULL"); | |
| } | |
| return -1; | |
| } |
We should update the documentation to reflect that.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
Metadata
Metadata
Assignees
Labels
type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error