KEMBAR78
gh-124176: Add special support for dataclasses to `create_autospec` by sobolevn · Pull Request #124429 · python/cpython · GitHub
Skip to content

gh-124176: Add special support for dataclasses to create_autospec #124429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2024
Merged

gh-124176: Add special support for dataclasses to create_autospec #124429

merged 4 commits into from
Sep 27, 2024

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 24, 2024 •
edited by bedevere-app bot
Loading

Now creating autospecs from dataclass types is easier. We inspect all fields and add them to __dir__, so mock's spec will know about future dataclass instance fields.

@sobolevn sobolevn requested a review from cjw296 as a code owner September 24, 2024 10:45
@bedevere-app bedevere-app bot mentioned this pull request Sep 24, 2024
Open
ericvsmith
ericvsmith reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a user of unittest.mock, but these changes look reasonable to me.

carljm
carljm approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me as well.

cjw296
cjw296 reviewed Sep 26, 2024
View reviewed changes
cjw296
cjw296 requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@cjw296 cjw296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supportive of the change, just the code hygiene changes to make.

@bedevere-app
Copy link

bedevere-app bot commented Sep 26, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@sobolevn
Copy link
Member Author

@cjw296 done! 👍

cjw296
cjw296 reviewed Sep 26, 2024
View reviewed changes
ncoghlan
ncoghlan approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I especially like the test coverage.

cjw296
cjw296 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@cjw296 cjw296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sobolevn sobolevn merged commit 3a0e7f5 into python:main Sep 27, 2024
35 of 36 checks passed
@sobolevn
Copy link
Member Author

Thanks everyone! 🎉

@cdce8p cdce8p mentioned this pull request Jun 10, 2025
Closed
@sobolevn sobolevn mentioned this pull request Jun 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjw296 cjw296 cjw296 approved these changes

@ncoghlan ncoghlan ncoghlan approved these changes

@carljm carljm carljm approved these changes

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @carljm @ericvsmith @cjw296 @ncoghlan