KEMBAR78
gh-128049: Fix type confusion bug with the return value of a custom ExceptionGroup split function by Nico-Posada · Pull Request #128079 · python/cpython · GitHub
Skip to content

gh-128049: Fix type confusion bug with the return value of a custom ExceptionGroup split function #128079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 20, 2024
Merged

gh-128049: Fix type confusion bug with the return value of a custom ExceptionGroup split function #128079

merged 7 commits into from
Dec 20, 2024

Conversation

@Nico-Posada
Copy link
Contributor

@Nico-Posada Nico-Posada commented Dec 18, 2024 •
edited by bedevere-app bot
Loading

Fixes #128049

Still new to this whole process so feedback is appreciated :)

@bedevere-app bedevere-app bot mentioned this pull request Dec 18, 2024
Closed
@iritkatriel
Copy link
Member

Labelling as do not merge until discussion on the issue is resolved.

iritkatriel
iritkatriel reviewed Dec 18, 2024
View reviewed changes
iritkatriel
iritkatriel reviewed Dec 18, 2024
View reviewed changes
iritkatriel
iritkatriel reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just made a few stylistic suggestions.

@iritkatriel iritkatriel added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed DO-NOT-MERGE labels Dec 20, 2024
@iritkatriel
Copy link
Member

Thank you @Nico-Posada !

@iritkatriel iritkatriel enabled auto-merge (squash) December 20, 2024 18:57
@iritkatriel iritkatriel merged commit 3879ca0 into python:main Dec 20, 2024
40 of 41 checks passed
@miss-islington-app
Copy link

Thanks @Nico-Posada for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2024
@Nico-Posada @miss-islington
pythongh-128049: Fix type confusion bug with the return value of a cu…
40d1444 
…stom ExceptionGroup split function (pythonGH-128079)

(cherry picked from commit 3879ca0)

Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2024
@Nico-Posada @miss-islington
pythongh-128049: Fix type confusion bug with the return value of a cu…
f8e3ca4 
…stom ExceptionGroup split function (pythonGH-128079)

(cherry picked from commit 3879ca0)

Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2024

GH-128139 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 20, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2024

GH-128140 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 20, 2024
iritkatriel pushed a commit that referenced this pull request Dec 20, 2024
@miss-islington @Nico-Posada
[3.13] gh-128049: Fix type confusion bug with the return value of a c…
09d15aa 
…ustom ExceptionGroup split function (GH-128079) (#128139)

gh-128049: Fix type confusion bug with the return value of a custom ExceptionGroup split function (GH-128079)
(cherry picked from commit 3879ca0)

Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com>
iritkatriel pushed a commit that referenced this pull request Dec 20, 2024
@miss-islington @Nico-Posada
[3.12] gh-128049: Fix type confusion bug with the return value of a c…
f65ac86 
…ustom ExceptionGroup split function (GH-128079) (#128140)

gh-128049: Fix type confusion bug with the return value of a custom ExceptionGroup split function (GH-128079)
(cherry picked from commit 3879ca0)

Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Dec 23, 2024
@Nico-Posada @srinivasreddy
pythongh-128049: Fix type confusion bug with the return value of a cu…
349b5ec 
…stom ExceptionGroup split function (python#128079)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@Nico-Posada @srinivasreddy
pythongh-128049: Fix type confusion bug with the return value of a cu…
c951daf 
…stom ExceptionGroup split function (python#128079)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Return value of <ExceptionGroup class>.split has insufficient checks leading to a type confusion bug

2 participants

@Nico-Posada @iritkatriel