gh-132285: Fix that __annotate__ is not deleted when __annotations__ is deleted
#132286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
force-pushed
the
issue-132285
branch
2 times, most recently
from
13bb12e to
8e65065
Compare
|
I think this actually behaves incorrectly. In https://peps.python.org/pep-0749/#effect-of-deleting-annotations we said that deleting |
|
Yes, sure :) |
sobolevn
changed the title
__annotations__ is deleted__annotate__ is not deleted when __annotations__ is deleted
JelleZijlstra
approved these changes
Apr 9, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…ations__` is deleted (python#132286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__annotate__corner case when deleting__annotations__#132285