-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
Closed
Labels
3.14bugs and security fixesbugs and security fixes3.15new features, bugs and security fixesnew features, bugs and security fixesextension-modulesC modules in the Modules dirC modules in the Modules dirtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Bug report
Bug description:
I thought I add 3.14-dev to our CI on github actions and after fixing some obvious issues, this one was left (the code is tested successfully on 3.10 .. 3.13):
File "/home/runner/work/borg/borg/src/borg/archiver/create_cmd.py", line 472, in _rec_walk
with OsOpen(
~~~~~~^
path=path, parent_fd=parent_fd, name=name, flags=flags_dir, noatime=True, op="dir_open"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
) as child_fd:
^
File "/opt/hostedtoolcache/Python/3.14.0-beta.2/x64/lib/python3.14/contextlib.py", line 162, in __exit__
self.gen.throw(value)
~~~~~~~~~~~~~~^^^^^^^
File "/home/runner/work/borg/borg/src/borg/archive.py", line 254, in OsOpen
yield fd
TypeError: _pystart_callback expected 2 arguments, got 3We use tox and pytest as test runner, in case that matters. Tried updating these (plus their plugins) to the latest versions, but it did not help.
CPython versions tested on:
3.14.0b2
Operating systems tested on:
Linux
Linked PRs
Metadata
Metadata
Assignees
Labels
3.14bugs and security fixesbugs and security fixes3.15new features, bugs and security fixesnew features, bugs and security fixesextension-modulesC modules in the Modules dirC modules in the Modules dirtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error