KEMBAR78
[3.10] gh-97786: Fix compiler warnings in pytime.c (GH-101826) by mdickinson · Pull Request #102150 · python/cpython · GitHub
Skip to content

[3.10] gh-97786: Fix compiler warnings in pytime.c (GH-101826) #102150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2023
Merged

[3.10] gh-97786: Fix compiler warnings in pytime.c (GH-101826) #102150

merged 3 commits into from
Feb 26, 2023

Conversation

@mdickinson
Copy link
Member

@mdickinson mdickinson commented Feb 22, 2023 •
edited by bedevere-bot
Loading

Fixes compiler warnings in pytime.c..
(cherry picked from commit b1b375e)

@mdickinson
[3.10] pythongh-97786: Fix compiler warnings in pytime.c (pythonGH-10…
3d56ece 
…1826)

Fixes compiler warnings in pytime.c..
(cherry picked from commit b1b375e)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
This was referenced Feb 22, 2023
Closed
Merged
@mdickinson mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 3d56ece 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2023
@gpshead
Copy link
Member

gpshead commented Feb 23, 2023

!buildbot wasm

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit a54b679 🤖

The command will test the builders whose names match following regular expression: wasm

The builders matched are:

  • wasm32-emscripten node (pthreads) PR
  • wasm32-emscripten browser (dynamic linking, no tests) PR
  • wasm32-wasi PR
  • wasm32-emscripten node (dynamic linking) PR

abalkin
abalkin approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@abalkin abalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has already been merged in main (gh-97786), there isn't real need for a review.

In any case, LGTM. I just added a suggestion that should not hold this from being merged.

@mdickinson mdickinson merged commit 5b610b5 into python:3.10 Feb 26, 2023
@mdickinson mdickinson deleted the backport-b1b375e-3.10 branch February 26, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abalkin abalkin abalkin approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdickinson @bedevere-bot @gpshead @abalkin