KEMBAR78
gh-102344: implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx by maxbachmann · Pull Request #102345 · python/cpython · GitHub
Skip to content

gh-102344: implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx #102345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 1, 2023
Merged

gh-102344: implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx #102345

merged 10 commits into from
Mar 1, 2023

Conversation

@maxbachmann
Copy link
Contributor

@maxbachmann maxbachmann commented Feb 28, 2023 •
edited by bedevere-bot
Loading

Some review already took place in #102256:

  • implementation for QueryValueEx / SetValueEx should possibly be cleaned up as well by using a similar structure
  • The two could possibly share some part of the implementation

@maxbachmann maxbachmann requested a review from a team as a code owner February 28, 2023 22:10
@bedevere-bot bedevere-bot mentioned this pull request Feb 28, 2023
Closed
@maxbachmann maxbachmann mentioned this pull request Feb 28, 2023
Merged
eryksun
eryksun reviewed Mar 1, 2023
View reviewed changes
maxbachmann and others added 2 commits March 1, 2023 02:36
@maxbachmann @eryksun
Update PC/winreg.c
2c95f23 
Co-authored-by: Eryk Sun <eryksun@gmail.com>
@maxbachmann
revert part
8a4543b
zooba
zooba reviewed Mar 1, 2023
View reviewed changes
@zooba zooba merged commit c1748ed into python:main Mar 1, 2023
@eryksun
Copy link
Contributor

eryksun commented Mar 1, 2023

Why did you revert the update of winreg_QueryValueEx_impl()? Did it cause tests to fail?

@maxbachmann
Copy link
Contributor Author

yes I reverted it, since it caused test timeouts. I was not directly sure what I did wrong, so I reverted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksun eryksun eryksun left review comments

@zooba zooba zooba left review comments

Assignees

No one assigned

Labels

OS-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maxbachmann @eryksun @zooba @bedevere-bot