KEMBAR78
gh-104876: Remove deprecated turtle.RawTurtle.settiltangle by hugovk · Pull Request #104877 · python/cpython · GitHub
Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented May 24, 2023

Closes #104876.

Remove the turtle.RawTurtle.settiltangle method, deprecated in docs since Python 3.1 and with a warning since Python 3.11.


📚 Documentation preview 📚: https://cpython-previews--104877.org.readthedocs.build/

@hugovk hugovk added 3.13 bugs and security fixes and removed awaiting core review labels May 24, 2023
@hugovk hugovk changed the title Remove deprecated turtle.RawTurtle.settiltangle gh-104876: Remove deprecated turtle.RawTurtle.settiltangle May 24, 2023
@hugovk hugovk added the stdlib Standard Library Python modules in the Lib/ directory label May 25, 2023
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I left minor remarks. Also, I never used the turtle module, so I don't know how to test this change. Lib/test/test_turtle.py checks that there is no regression, no?

hugovk and others added 3 commits May 25, 2023 19:16
Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hugovk hugovk merged commit 10c4583 into python:main May 26, 2023
@hugovk hugovk deleted the rm-turtle-settiltangle branch May 26, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.13 bugs and security fixes stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated turtle.RawTurtle.settiltangle method

3 participants