KEMBAR78
gh-105111: remove deprecated macros Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END by iritkatriel · Pull Request #105112 · python/cpython · GitHub
Skip to content

gh-105111: remove deprecated macros Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END #105112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 31, 2023
Merged

gh-105111: remove deprecated macros Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END #105112

merged 6 commits into from
May 31, 2023

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented May 30, 2023 •
edited by github-actions bot
Loading

@iritkatriel iritkatriel requested a review from vstinner May 30, 2023 19:34
@bedevere-bot bedevere-bot mentioned this pull request May 30, 2023
Closed
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label May 30, 2023
vstinner
vstinner reviewed May 31, 2023
View reviewed changes
iritkatriel
iritkatriel commented May 31, 2023
View reviewed changes
vstinner
vstinner reviewed May 31, 2023
View reviewed changes
iritkatriel and others added 2 commits May 31, 2023 13:08
@iritkatriel @vstinner
Apply suggestions from code review
84e4517 
Co-authored-by: Victor Stinner <vstinner@python.org>
@iritkatriel
Merge branch 'main' into trashcan
9fb454a
vstinner
vstinner approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for handling this one.

@iritkatriel iritkatriel merged commit fbc9d0d into python:main May 31, 2023
@iritkatriel iritkatriel deleted the trashcan branch July 25, 2023 18:04
@webknjaz webknjaz mentioned this pull request Feb 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated Py_TRASHCAN_SAFE_BEGIN/ Py_TRASHCAN_SAFE_END

3 participants

@iritkatriel @vstinner @bedevere-bot