KEMBAR78
GH-105684: Require asyncio Task implementations to support `set_name` method by kumaraditya303 · Pull Request #105685 · python/cpython · GitHub
Skip to content

GH-105684: Require asyncio Task implementations to support set_name method #105685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 13, 2023
Merged

GH-105684: Require asyncio Task implementations to support set_name method #105685

merged 8 commits into from
Jun 13, 2023

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 12, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jun 12, 2023
Closed
@gvanrossum gvanrossum changed the title GH-105684: Make name for asyncio tasks mandatory GH-105684: Require asyncio Task implementations to support set_name method Jun 12, 2023
gvanrossum
gvanrossum approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I recomment applying my suggestion to the NEWS item calling out the disappearance of _set_task_name. (Also, could you check if this breaks uvloop?)

@kumaraditya303 @gvanrossum
Update Misc/NEWS.d/next/Library/2023-06-12-10-40-38.gh-issue-105684.y…
bead3a7 
…iHkFD.rst

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
@kumaraditya303
Copy link
Contributor Author

(Also, could you check if this breaks uvloop?

No uvloop does not uses this function nor it implements a custom task implementation so is unaffected from this change.

@kumaraditya303 kumaraditya303 enabled auto-merge (squash) June 12, 2023 20:19
@kumaraditya303 kumaraditya303 disabled auto-merge June 13, 2023 04:20
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) June 13, 2023 05:39
@kumaraditya303 kumaraditya303 disabled auto-merge June 13, 2023 05:39
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) June 13, 2023 05:42
@kumaraditya303 kumaraditya303 merged commit 840d02f into python:main Jun 13, 2023
@kumaraditya303 kumaraditya303 deleted the task-set-name branch June 13, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaraditya303 @gvanrossum @bedevere-bot