KEMBAR78
gh-106487: Allow the 'count' argument of `str.replace` to be a keyword by hugovk · Pull Request #106488 · python/cpython · GitHub
Skip to content

gh-106487: Allow the 'count' argument of str.replace to be a keyword #106488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2023
Merged

gh-106487: Allow the 'count' argument of str.replace to be a keyword #106488

merged 4 commits into from
Jul 10, 2023

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Jul 6, 2023 •
edited by github-actions bot
Loading

Before

>>> "aa".replace("a", "b")
'bb'
>>> "aa".replace("a", "b", 1)
'aa'
>>> "aa".replace("a", "b", count=1)
TypeError: str.replace() takes no keyword arguments

After

>>> "aa".replace("a", "b")
'bb'
>>> "aa".replace("a", "b", 0)
'aa'
>>> "aa".replace("a", "b", count=0)
'aa'
>>> "aa".replace("a", "b", 1)
'ba'
>>> "aa".replace("a", "b", count=1)
'ba'
>>> "aa".replace("a", "b", 2)
'bb'
>>> "aa".replace("a", "b", count=2)
'bb'
>>> "aa".replace("a", "b", 3)
'bb'
>>> "aa".replace("a", "b", count=3)
'bb'

📚 Documentation preview 📚: https://cpython-previews--106488.org.readthedocs.build/

@hugovk hugovk added the 3.13 bugs and security fixes label Jul 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 6, 2023
Closed
@hugovk hugovk changed the title gh-106487: Allow the *count* argument of str.replace to be a keyword gh-106487: Allow the 'count' argument of str.replace to be a keyword Jul 6, 2023
vstinner
vstinner reviewed Jul 6, 2023
View reviewed changes
vstinner
vstinner approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk merged commit 34c1414 into python:main Jul 10, 2023
@hugovk hugovk deleted the str-replace-keyword-count branch July 10, 2023 09:52
@vstinner
Copy link
Member

vstinner commented Jul 10, 2023 •
edited
Loading

Nice enhancement. It's funny to have Mastodon driven development 😁

@hugovk
Copy link
Member Author

hugovk commented Jul 10, 2023

T[witter]DD is so last year.

@arvindavoudi arvindavoudi mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

3.13 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk @vstinner @bedevere-bot