gh-106751: Optimize SelectSelector.select() for many iteration case #106879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar technique can be adopted. Benchmarkimport timeit
import os
from selectors import SelectSelector, EVENT_WRITE, EVENT_READ
select = SelectSelector()
for _ in range(100):
r, w = os.pipe()
os.write(w, b"a")
select.register(r, EVENT_READ)
elapsed = timeit.timeit(
"selector.select()",
number=100000,
globals={"selector": select},
)
print(f"elapsed: {elapsed}")
ResultAS-IS: elapsed -> 2.051669834000222 |
|
cc @eendebakpt |
methane
approved these changes
Jul 19, 2023
eendebakpt
reviewed
Jul 19, 2023
| events |= EVENT_WRITE | ||
|
|
||
| key = self._fd_to_key.get(fd) | ||
| r = frozenset(r) |
There was a problem hiding this comment.
Note: on my system frozenset is slightly slower than set, but the difference is very small
| key = self._fd_to_key.get(fd) | ||
| r = frozenset(r) | ||
| w = frozenset(w) | ||
| rw = r | w |
There was a problem hiding this comment.
The rw is only used once. You assigned r | w to a variable for readability?
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: gh-106751