KEMBAR78
[3.12] GH-106897: Add `RERAISE` event to `sys.monitoring`. (GH-107291) by markshannon · Pull Request #107346 · python/cpython · GitHub
Skip to content

Conversation

@markshannon
Copy link
Member

@markshannon markshannon commented Jul 27, 2023

Manual backport of GH-107291.

@Yhg1s as release manager.

Fixes an omission in PEP 669, resulting in an imbalance between raise and unwind/handle events for exceptions.

…07291)

* Ensures that exception handling events are balanced. Each [re]raise event has a matching unwind/handled event.
@markshannon markshannon changed the title GH-106897: Add RERAISE event to sys.monitoring. (GH-107291) [3.12] GH-106897: Add RERAISE event to sys.monitoring. (GH-107291) Jul 27, 2023
markshannon and others added 2 commits July 27, 2023 13:54
…e-106897.EsGurc.rst

Co-authored-by: T. Wouters <thomas@python.org>
@markshannon
Copy link
Member Author

The ABI checking tool claims that the ABI has changed.
Why is the internal layout of PyInterpreterState part of the ABI?

@Yhg1s
Copy link
Member

Yhg1s commented Jul 27, 2023

The ABI checking tool claims that the ABI has changed. Why is the internal layout of PyInterpreterState part of the ABI?

Because it's reachable through symbols exposed in the ABI. The ABI checking tool is not tightly constrained, and errs on the side of caution. (I'm sure we'd all be happy if you wanted to spend some time creating an accurate checking tool with no false negatives and fewer false positives :)

@markshannon
Copy link
Member Author

The ABI file diff is a quite a lot larger than I would have liked, but it seems to be OK.
@Yhg1s are you OK with merging the updated ABI file?

@markshannon
Copy link
Member Author

I've waded through the Doc/data/python3.12.abi diff, and the changes are as expected, plus a lot of line number changes and some reordering.

@markshannon markshannon merged commit 3b1a4c1 into python:3.12 Jul 28, 2023
@markshannon markshannon deleted the backport-107291 branch July 28, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants