@erlend-aasland -- Unsure on correct practice here, I would normally apply backport labels for docs PRs, but as this introduces AC, it may not be correct to backport the change. What would you advise?

A

@erlend-aasland -- Unsure on correct practice here, I would normally apply backport labels for docs PRs, but as this introduces AC, it may not be correct to backport the change. What would you advise?

IIRC, we generally do not backport PRs that introduce Argument Clinic.

Thanks for the review! I've applied your suggestions :) Just wondering, since the docstrings were taken mostly verbatim from the docs, should we also update the docs (e.g. use the imperative there as well)?

Thanks for the review! I've applied your suggestions :) Just wondering, since the docstrings were taken mostly verbatim from the docs, should we also update the docs (e.g. use the imperative there as well)?

IMO, that would be an improvement. I'd do it in a follow-up PR, so we could backport through to 3.11. IMO, we should normalise the wording in the entire prose of that page, so one section at the time could make sense.

FTR, I did a similar operation for the sqlite3 docs last year, though through multiple PRs.

Thanks!